Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/include handlers in build #1414

Merged
merged 13 commits into from
Dec 9, 2024
Merged

Conversation

TheOrangePuff
Copy link
Contributor

Description of the proposed changes

  • NX uses the root .gitignore and .npmignore when building npm packages. So we have to write custom logic if we want to include ignore files in specific packages. This PR adds a script to handle that
  • Removes all ignore files that weren't needed
  • Configures NX to include additional required package assets

Notes to reviewers

When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

Copy link
Contributor

@AdamJHall AdamJHall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@TheOrangePuff TheOrangePuff merged commit 7b8f77a into main Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants